Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pokemon Emerald: Fix opponent blacklist checking wrong option for legendaries shortcut #4058

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Pokemon Emerald: Fix opponent blacklist checking wrong option for legendaries shortcut #4058

merged 1 commit into from
Oct 15, 2024

Conversation

Zunawe
Copy link
Collaborator

@Zunawe Zunawe commented Oct 14, 2024

What is this fixing or adding?

Copy/paste error left the opponent blacklist checking the _Legendaries alias in the starter blacklist option instead of the trainer party blacklist option.

How was this tested?

Inspected the value of self.blacklisted_opponent_pokemon after this change when _Legendaries is in trainer_party_blacklist.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Oct 14, 2024
@Zunawe Zunawe added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: release/blocker Issues/PRs that must be addressed before next official release. labels Oct 14, 2024
@Exempt-Medic
Copy link
Member

Why is this a release blocker? Does it make worlds impossible to complete?

Exempt-Medic
Exempt-Medic approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, is simple enough, and it generates.

@Zunawe
Copy link
Collaborator Author

Zunawe commented Oct 14, 2024 •
edited
Loading

Why is this a release blocker? Does it make worlds impossible to complete?

Doesn't affect beatability. For me, if the player specifies something clearly in their options and does not get it, I consider it quite severe. I would have labeled the special range fix that affects R/B and Emerald HM compatibility as a release blocker for similar reasons, even though that also doesn't affect beatability.

afaik, we don't have anything codified for what should count as release/blocker. If the tag should be removed from this PR, so be it.

@Exempt-Medic
Copy link
Member

https://discord.com/channels/731205301247803413/731214280439103580/1222833633858031617

https://discord.com/channels/731205301247803413/731214280439103580/1222123434327150603

But I agree, these aren't exact or codified. I will ask again.

@NewSoupVi NewSoupVi merged commit 26577b1 into ArchipelagoMW:main Oct 15, 2024
18 checks passed
@Zunawe Zunawe mentioned this pull request Oct 28, 2024
Merged
@Zunawe Zunawe deleted the emerald-fix-blacklist branch November 12, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

Assignees
No one assigned
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zunawe @Exempt-Medic @NewSoupVi